Re: [patch] arptables Makefile cleanup and honour DESTDIR

Op ma, 13-08-2007 te 16:46 +0400, schreef Peter Volkov:
> Hello, Bart.
> 
> Thank you for applying previous patches. Of course your corrections were
> right. In attachment there is similar patch for arptables Makefile.
> Besides changing DESTDIR, there are other two small changes (I do not
> think worth separate patches):
> 1. It removes completely not used anywhere EXTRAS, EXTRA_INSTALLS and
> $(BINDIR)/arptables.
> 2. Removes -DIPT_LIB_DIR=\"$(IPT_LIBDIR)\" as it is not used anywhere
> else in the code.

Looks good, applied. I'm wondering: don't you want

$(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8
	mkdir -p $(@D)
	install -m 0644 -o root -g root $< $@

instead of

$(MANDIR)/man8/arptables.8: arptables.8
	mkdir -p $(DESTDIR)$(@D)
	install -m 0644 -o root -g root $< $(DESTDIR)$@

?

> BTW. arptables-0.0.3-2 does not compiles with the recent kernels. Is
> there any ETA for new release?

I'll release 0.0.3-3 as soon as the above question is resolved :)

cheers,
Bart



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/