Re: [PATCH] IPv6 dnat/snat support

Bart De Schuymer wrote on Sunday, February 10, 2008 9:21 AM:

> Op vr, 08-02-2008 te 16:01 -0800, schreef Tseng, Kuo-Lang:
>> Bart De Schuymer wrote on Friday, February 08, 2008 10:21 AM:
>> 
>>> Hi Kuo,
>>> 
>>> Thanks for your patch. The patch looks ok. Tiny comment: the header
>>> diffs belong in the kernel patch and the userspace patch lacks a
>>> man page update. Seems like we'll need a merge of the two kernel
>>> patches and extra userspace code. 
>>> 
>>> I was gonna give my say about posting to netfilter-devel only,
>>> without userspace code, but I guess I'm better off restraining
>>> myself from doing that. 
>>> 
>>> cheers,
>>> Bart
>> 
>> Thanks. I have attached an updated userspace patch that includes the
>> missing man page update and removed the header diffs.
> 
> It would be better if the ipv6 address and traffic class matching were
> implemented in the patch. So I'm going to wait for that. Is there any
> reason why you didn't do this in the first place?
We wanted to keep the first patch small for the review. Once the first
patch is merged in, the v6 address and traffic class can be added after
that.  

> 
>> I will post to the netfilter-devel for the kernel code.
> 
> I don't read netfilter-devel, so at least CC ebtables-devel. Until
> ebtables becomes an official part of the netfilter code (currently)
> under Patrick's control it's common courtesy to mail to
> ebtables-devel. 
Sure. I will CC ebtables-devel next time when I send emails to
netfilter-devel. (Same kernel patch that I sent in this thread has been
posted to netfilter-devel.) 

> 
> cheers,
> Bart


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/