Re: [PATCH 4/5] adds AF_BRIDGE support to IP2STR

--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

This patchset is fine but

On Monday, 2008 February 11 at 23:07:57 +0100, Peter Warasin wrote:
> This patch make the ip address string converter AF_BRIDGE
> compatible and add ip address ARP keys in order to make
> them also convert.
> +	[KEY_ARP_SPA] =3D {
> +		.type =3D ULOGD_RET_IPADDR,
> +		.flags =3D ULOGD_RETF_NONE,
> +		.name =3D "arp.saddr",
> +	},
> +	[KEY_ARP_TPA] =3D {
> +		.type =3D ULOGD_RET_IPADDR,
> +		.flags =3D ULOGD_RETF_NONE,
> +		.name =3D "arp.daddr",
> +	},

you defined here arp.daddr as ULOGD_RET_IPADDR although you've defined it in
BASE plugin as:
	[KEY_ARP_SPA] =3D {
		.type =3D ULOGD_RET_RAW,
		.flags =3D
			ULOGD_RETF_NONE,
		.name =3D
			"arp.saddr",
	},

This should work in current state code but it is only luck.

BR,
--=20
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHsgFRnxA7CdMWjzIRAuN0AJkB+2TozqStZXKefiF00JKkiCkBLwCfQzw6
I/QNUzFIZsZZFephtrLga5s=
=/JOQ
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html