Re: [PATCH resend 1/2] Adds ebt_nflog watcher to kernel.

Bart De Schuymer wrote:
> Op di, 26-02-2008 te 00:03 +0100, schreef Peter Warasin:
>> Hi
>>
>> Patrick McHardy wrote:
>>> Peter Warasin wrote:
>>>  > This patch adds the ebtables nflog watcher to the
>>>  > kernel
>>> This seems mostly fine to me. A few minor comments:
>>> If you'll resend the patch based on net-2.6.26 I'll queue it
>>> if Bart has no objections.
>> I re-based on net-2.6.26 and changed what you mentioned.
>> Patch is attached
> 
> It looks fine, I'm just wondering what the flags and the pad in struct
> ebt_nflog_info are for...

Both have their origin in NFLOG.

The flags were intended for something I still want to add, a reliable
log mode where packets are dropped when netlink transmission or
memory allocation fails. I can't really remember why I added the
padding, but in any case it doesn't hurt since the structure size
is usually padded to a multiple of 4/8 anyways.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/