Re: [PATCH 2/2] Add IPv6 support
"Tseng, Kuo-Lang" <[email protected]> Thu, 10 Apr 2008 13:23:17 -0700
| Newsgroups | gmane.linux.network.bridge.ebtables.devel,gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <3F25FE8C477E9E4FB3D42C2FF937C08AC9B75E@orsmsx423.amr.corp.intel.com> |
Patrick McHardy wrote on Tuesday, April 08, 2008 10:38 AM: > > > I wanted to apply this, but the patch has multiple checkpatch > errors. There are also some codingstyle errors checkpatch doesn't > complain about, like: > > + for (i = 0; i < 4; i++) > + tmp_addr.in6_u.u6_addr32[i] = > ih6->saddr.in6_u.u6_addr32[i] & ^^^ needs tab > > It also seems the TCP/UDP/.. logging part could be shared between > IPv4 and IPv6. The protocol checks seem to be missing UDPLITE. > > Please fix those up and resend, thanks. I'll fix and re-send the patch next week. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone