Re: ARP match extension for MACs

Le mer 30/04/2003 à 08:28, Bart De Schuymer a écrit :
> Thanks, I'll take a closer look later this week. It looks good, some details I 
> spotted:
> - the #include <linux/if_ether.h> should not be in the header file, put it in 
> the c-files if necessary.

I moved this include on top of c-files, both userspace and kernel
ebt_arp.c.

> - In parse() there's a use of ARP_IP_D that should be ARP_MAC_D.

Oops. In fact, it should be ARP_MAC_S. My code is mostly based on
existing one, must have been a copy/paste residu.

New patch is attached. For 2.5 files were mostly the same, I added
changes to them, but did not test. I hope it will be OK this time. It's
the first time I ever patch something related to kernel, I am not used
with coding style.


-- 
Cédric Blancher  <blancher-cPThYx3uDionEikN29/[email protected]>
IT systems and networks security - Cartel Sécurité
Phone : +33 (0)1 44 06 97 87 - Fax: +33 (0)1 44 06 97 99
PGP KeyID:157E98EE  FingerPrint:FA62226DA9E72FA8AECAA240008B480E157E98EE