RE: [RELEASE] ebtables-brnf-11_vs_2.4.31

Hi, there seems to be a bug in the new patch. It doesn't compile, it breaks
here:

br_stp_bpdu.c: In function `br_stp_handle_bpdu':
br_stp_bpdu.c:146: error: `br' undeclared (first use in this function)
br_stp_bpdu.c:146: error: (Each undeclared identifier is reported only once
br_stp_bpdu.c:146: error: for each function it appears in.)

The patch was applied cleanly:

###
trauco:/usr/src/linux-2.4.31# find . -name "*.rej" -print | wc -l
0
###

Looking at the offending line:

###
        /* insert into forwarding database after filtering to avoid spoofing
*/
        br_fdb_insert(br, p, skb->mac.ethernet->h_source, 0);
###

"br" is undeclared, looking at br_input.c for some clues (never looked at
bridge-nf source before) found this:

###
int br_handle_frame_finish(struct sk_buff *skb)
{
        struct net_bridge *br;

[snip]

        /* insert into forwarding database after filtering to avoid spoofing
*/
                br_fdb_insert(br, p, skb->mac.ethernet->h_source, 0);

        br = p->br;
###

This also looks suspicious, because when calling br_fdb_insert, br isn't set
yet. So the patch is probably wrong?

Thanks,
Ivan Toledo


-----Mensaje original-----
De: ebtables-user-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
[mailto:ebtables-user-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] En nombre de Bart De
Schuymer
Enviado el: Jueves, 15 de Septiembre de 2005 14:30
Para: ebtables-user
Asunto: [Ebtables-user] [RELEASE] ebtables-brnf-11_vs_2.4.31

Hi,

Just released ebtables-brnf-11.

Changes:

- update fdb after PREROUTING, enabling dropping the packets before the
fdb is updated (originally from Stephen Hemminger).
- fix possible iptables redirect problem (originally from Mark Glines
<[email protected]>)

cheers,
Bart




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Ebtables-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ebtables-user



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php