Re: VLAN interface on top of the bridge interface

Hi Stephen,

I've applied your patch against 2.6.16.9 vanilla kernel. Seems to be 
working perfectly. I haven't checked it in production environment yet, 
but in test setup it works like a charm. So now I have vlan interfaces 
on top of the bridge interface and can send/receive full size packets 
without any problems. Thank you very much for your help.

Will something like this finds its way to Linus kernel tree? Is any 
additional testing needed?

Best Regards,
Martin

[email protected] wrote:
> Hi Stephen,
> 
> looks promising. I will recompile and test. I should have test results 
> tomorrow
> at the evening (I need physicaly access the machine, to reconnect some 
> cables).
> Will let you know. Many Thanks!
> 
> Best Regards,
> Martin
> 
> Quoting Stephen Hemminger <[email protected]>:
> 
>> Please test this.
>>
>> --- bridge.orig/net/bridge/br_forward.c    2006-04-10 
>> 16:17:51.000000000 -0700
>> +++ bridge/net/bridge/br_forward.c    2006-04-19 13:50:42.000000000 -0700
>> @@ -16,6 +16,7 @@
>> #include <linux/kernel.h>
>> #include <linux/netdevice.h>
>> #include <linux/skbuff.h>
>> +#include <linux/if_vlan.h>
>> #include <linux/netfilter_bridge.h>
>> #include "br_private.h"
>>
>> @@ -29,10 +30,15 @@
>>     return 1;
>> }
>>
>> +static inline unsigned packet_length(const struct sk_buff *skb)
>> +{
>> +    return skb->len - (skb->protocol == htons(ETH_P_8021Q) ? 
>> VLAN_HLEN : 0);
>> +}
>> +
>> int br_dev_queue_push_xmit(struct sk_buff *skb)
>> {
>>     /* drop mtu oversized packets except tso */
>> -    if (skb->len > skb->dev->mtu && !skb_shinfo(skb)->tso_size)
>> +    if (packet_length(skb) > skb->dev->mtu && 
>> !skb_shinfo(skb)->tso_size)
>>         kfree_skb(skb);
>>     else {
>> #ifdef CONFIG_BRIDGE_NETFILTER
>>
> 
> 
> 
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
> 
> 
> 
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job 
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Ebtables-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ebtables-user


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642