Re: [PATCH] netfilter: add back NETFILTER_XTABLES dependencies

Arnd Bergmann <[email protected]> wrote:
> 
> Some Kconfig symbols were changed to depend on the 'bool' symbol
> NETFILTER_XTABLES_LEGACY, which means they can now be set to built-in
> when the xtables code itself is in a loadable module:
> 
> x86_64-linux-ld: vmlinux.o: in function `arpt_unregister_table_pre_exit':
> (.text+0x1831987): undefined reference to `xt_find_table'
> x86_64-linux-ld: vmlinux.o: in function `get_info.constprop.0':
> arp_tables.c:(.text+0x1831aab): undefined reference to `xt_request_find_table_lock'
> x86_64-linux-ld: arp_tables.c:(.text+0x1831bea): undefined reference to `xt_table_unlock'
> x86_64-linux-ld: vmlinux.o: in function `do_arpt_get_ctl':
> arp_tables.c:(.text+0x183205d): undefined reference to `xt_find_table_lock'
> x86_64-linux-ld: arp_tables.c:(.text+0x18320c1): undefined reference to `xt_table_unlock'
> x86_64-linux-ld: arp_tables.c:(.text+0x183219a): undefined reference to `xt_recseq'
> 
> Change these to depend on both NETFILTER_XTABLES and
> NETFILTER_XTABLES_LEGACY.

Thanks Arnd.  I thought we could just replace NETFILTER_XTABLES depends
with NETFILTER_XTABLES_LEGACY, but I missed the difference between
tristate and bool.

Acked-by: Florian Westphal <[email protected]>