Re: [PATCH net-next 1/2] bridge: Redirect to backup port when port is administratively down
Jakub Kicinski <[email protected]>
| Newsgroups | gmane.linux.network,gmane.linux.network.bridge |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 12 Aug 2025 11:02:12 +0300 Ido Schimmel wrote:
> /* redirect to backup link if the destination port is down */
> - if (rcu_access_pointer(to->backup_port) && !netif_carrier_ok(to->dev)) {
> + if (rcu_access_pointer(to->backup_port) &&
> + (!netif_carrier_ok(to->dev) || !netif_running(to->dev))) {
Not really blocking this patch, but I always wondered why we allow
devices with carrier on in admin down state. Is his just something we
have because updating 200 drivers which don't manage carrier today
would be a PITA? Or there's a stronger reason to allow this?
Hopefully I'm not misreading the patch..