Re: [PATCH net-next 02/10] net: bridge: BROPT_FDB_LOCAL_VLAN_0: Look up FDB on VLAN 0 on miss
Jakub Kicinski <[email protected]>
| Newsgroups | gmane.linux.network.bridge,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 4 Sep 2025 19:07:19 +0200 Petr Machata wrote:
> dst = br_fdb_find_rcu(br, eth_hdr(skb)->h_dest, vid);
> + if (unlikely(!dst && vid &&
> + br_opt_get(br, BROPT_FDB_LOCAL_VLAN_0))) {
What does the assembly look like for this? I wonder if we're not better
off with:
unlikely(!dst) && vid && br_opt..
Checking dst will be very fast here, and if we missed we're already
on the slow path. So maybe we're better off moving the rest of the
condition out of the fast path, too?