Re: [PATCH v14 nf-next 3/3] netfilter: nft_chain_filter: Add bridge double vlan and pppoe

Eric Woudstra <[email protected]> wrote:
> Ok. At the end of nft_do_chain_bridge() I've added (after removing
> skb->protocol munging):
> 
> 	if (offset && ret == NF_ACCEPT)
> 		skb_reset_network_header(skb);
> 
> To reset the network header, only when it had been changed.
> 
> Do you want this helper to return the offset, so it can be used here?

Makes sense, yes.

> >> +		skb_set_network_header(skb, offset);
> > 
> > I assume thats because the network header still points to
> > the ethernet header at this stage?
> 
> That is correct.

Can you add a comment to that effect?  (I assume it points not
to ethernet header but to the header that follows, e.g. pppoe).