Re: [PATCHv3 net-next 5/5] selftests/net: add offload checking test for virtual interface

2025-09-09, 08:18:52 +0000, Hangbin Liu wrote:
> +__check_offload()
> +{
> +	local dev=$1
> +	local opt=$2
> +	local expect=$3
> +
> +	ip netns exec "$ns" ethtool --json -k "$dev" | \
> +		jq -r -e ".[].\"$opt\".active == ${expect}" >/dev/null

Sorry Hangbin, I should have noticed this when we discussed the IPsec
test, since the problem is similar for the other features set in
netdev_compute_features_from_lowers:

`ethtool -k` does not test the dev->*_features (mpls, vlan, etc) set
in the new common function, it only checks dev->features and
dev->hw_features. So this will not test the new function.

-- 
Sabrina