Re: [PATCH 14/14] net: bridge: Describe @tunnel_hash member in net_bridge_vlan_group struct

Ido Schimmel <[email protected]>
Newsgroups gmane.linux.network.bridge
Message-ID <aUET_bbW6KyxtQKB__23368.025529065$1765873295$gmane$org@shredder>
On Mon, Dec 15, 2025 at 06:39:02PM +0700, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./net/bridge/br_private.h:267 struct member 'tunnel_hash' not described in 'net_bridge_vlan_group'
> 
> Fix it by describing @tunnel_hash member.
> 
> Fixes: efa5356b0d9753 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Bagas Sanjaya <[email protected]>
> ---
>  net/bridge/br_private.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 7280c4e9305f36..bf441ac1c4d38a 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -247,6 +247,7 @@ struct net_bridge_vlan {
>   * struct net_bridge_vlan_group
>   *
>   * @vlan_hash: VLAN entry rhashtable
> + * @tunnel_hash: tunnel rhashtable

While you are at it, I suggest making the comment a bit more useful.
Something like:

@tunnel_hash: Hash table to map from tunnel key ID (e.g., VXLAN VNI) to VLAN

>   * @vlan_list: sorted VLAN entry list
>   * @num_vlans: number of total VLAN entries
>   * @pvid: PVID VLAN id
> -- 
> An old man doll... just what I always wanted! - Clara
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.