Re: [PATCH net-next v2 13/14] net: bridge: mcast: use combined active state in fast/data path
Ido Schimmel <[email protected]>
| Newsgroups | gmane.linux.network.bridge,gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <20260208161228.GM154003@shredder> |
On Fri, Feb 06, 2026 at 03:52:19AM +0100, Linus Lüssing wrote:
> @@ -1081,6 +1101,20 @@ static bool br_ip6_multicast_querier_exists(struct net_bridge_mcast *brmctx)
> }
> #endif
>
> +static bool br_multicast_querier_exists(struct net_bridge_mcast *brmctx, int proto)
Nit: Can you change this to 'u16 proto'
> +{
> + switch (proto) {
> + case (ETH_P_IP):
And drop the parentheses?
> + return br_ip4_multicast_querier_exists(brmctx);
> +#if IS_ENABLED(CONFIG_IPV6)
> + case (ETH_P_IPV6):
> + return br_ip6_multicast_querier_exists(brmctx);
> +#endif
> + default:
> + return false;
> + }
> +}