Re: [PATCH net-next v2 14/14] net: bridge: mcast: add inactive state assertions
Ido Schimmel <[email protected]>
| Newsgroups | gmane.linux.network.bridge |
|---|---|
| Message-ID | <20260208161317.GN154003__26565.7646859594$1770567438$gmane$org@shredder> |
On Fri, Feb 06, 2026 at 03:52:20AM +0100, Linus Lüssing wrote:
> @@ -1418,10 +1418,29 @@ static struct sk_buff *br_multicast_alloc_query(struct net_bridge_mcast *brmctx,
> return NULL;
> }
>
> +static void br_ip4_multicast_assert_inactive(struct net_bridge_mcast *brmctx)
> +{
> + WARN_ON(br_multicast_snooping_active(brmctx, htons(ETH_P_IP), NULL));
Can't this be WARN_ON_ONCE()? If something is actually wrong, WARN_ON()
has the potential to flood the kernel log
> +}
> +
> +static void br_ip6_multicast_assert_inactive(struct net_bridge_mcast *brmctx)
> +{
> + WARN_ON(br_multicast_snooping_active(brmctx, htons(ETH_P_IPV6), NULL));
Same
> +}