Re: [PATCH net-next v4 10/14] net: bridge: mcast: track active state, bridge up/down
Ido Schimmel <[email protected]>
| Newsgroups | gmane.linux.network.bridge,gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <20260309174909.GB2044263@shredder> |
On Sat, Mar 07, 2026 at 05:45:44AM +0100, Linus Lüssing wrote:
> @@ -4431,6 +4437,9 @@ static void __br_multicast_open(struct net_bridge_mcast *brmctx)
> #if IS_ENABLED(CONFIG_IPV6)
> __br_multicast_open_query(brmctx->br, &brmctx->ip6_own_query);
> #endif
> +
> + /* bridge interface is up, maybe set multicast state to active */
> + br_multicast_update_active(brmctx);
> }
>
> static void br_multicast_open_locked(struct net_bridge *br)
> @@ -4478,6 +4487,9 @@ static void __br_multicast_stop(struct net_bridge_mcast *brmctx)
> timer_shutdown(&brmctx->ip6_other_query.delay_timer);
> timer_shutdown(&brmctx->ip6_own_query.timer);
> #endif
> +
> + /* bridge interface is down, set multicast state to inactive */
Noticed this while reviewing patch #14: The comments about the interface
being up / down are inaccurate when __br_multicast_{open,stop}() are
called for a per-VLAN multicast context