Re: [PATCH net-next 0/3] net: move netdev_compute_master_upper_features to ndo_set_features

Paolo Abeni <[email protected]>
Newsgroups gmane.linux.network.bridge,gmane.linux.network,gmane.linux.kernel
Message-ID <[email protected]>
On 3/10/26 8:45 AM, Hangbin Liu wrote:
> Currently, master devices (bonding, bridge, team) manually call
> netdev_compute_master_upper_features() scattered throughout their port
> add/remove operations. This approach requires each driver to remember
> to update features at the right times and leads to code duplication.
> 
> The series moves netdev_compute_master_upper_features() to callback
> ndo_set_features so that the offload compute could automatically
> invoked during feature updates when upper/lower device relationships
> change. This centralizes the feature computation flow and removes the
> burden from individual drivers.
> 
> ---
> Hangbin Liu (3):
>       net: use ndo_set_features to set offload features for bonding/bridge/team
>       failover: use ndo_set_features for failover offload compute
>       net: no need to disable LRO specifically
> 
>  drivers/net/bonding/bond_main.c | 14 +++++----
>  drivers/net/net_failover.c      | 67 +++++------------------------------------
>  drivers/net/team/team_core.c    | 15 ++++-----
>  include/net/net_failover.h      |  7 -----
>  net/8021q/vlan.c                |  2 --
>  net/bridge/br_device.c          |  7 +++++
>  net/bridge/br_if.c              |  6 ----
>  net/core/dev.c                  |  8 +++--
>  net/hsr/hsr_slave.c             |  1 -
>  9 files changed, 37 insertions(+), 90 deletions(-)

I'm dropping this series from PW due to the self-tests failures. I guess
it could be restored later if it turns out the real problem is elsewhere.

/P
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.