Re: [PATCH net-next v3 5/5] selftests: net: bridge: add tests for MRC and QQIC validation
Jakub Kicinski <[email protected]>
| Newsgroups | gmane.linux.network.bridge,gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 3 Apr 2026 15:00:50 +0000 Ujjal Roy wrote: > --- a/tools/testing/selftests/net/forwarding/.gitignore > +++ b/tools/testing/selftests/net/forwarding/.gitignore > @@ -1,3 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > forwarding.config > ipmr > +mc_encode > +mc_decode please keep this file sorted > diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile > index bbaf4d937dd8..a26da846632d 100644 > --- a/tools/testing/selftests/net/forwarding/Makefile > +++ b/tools/testing/selftests/net/forwarding/Makefile > @@ -1,5 +1,15 @@ > # SPDX-License-Identifier: GPL-2.0+ OR MIT > > +top_srcdir = ../../../../.. > + > +CFLAGS += -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES) > +CFLAGS += -I$(top_srcdir)/tools/include Could you please keep the format more aligned with the ksft net/Makefile? Also is the -I$(top_srcdir)/tools/include still necessary? KHDR_INCLUDES don't include $src/usr/include ?? > +TEST_GEN_FILES := \ > + mc_encode \ > + mc_decode \ > +# end of TEST_GEN_FILES Also needs to be sorted -- pw-bot: cr