Re: [PATCH net 1/4] eth: bnxt: cancel IRQ notifier before freeing affinity mask

On Mon, Aug 3, 2026 at 1:01 PM Michael Chan <[email protected]> wrote:
>
> On Mon, Aug 3, 2026 at 12:31 PM Jakub Kicinski <[email protected]> wrote:
> >
> > bnxt_irq_affinity_notify() copies into irq->cpu_mask.
> > Cancel the notifier before freeing irq->cpu_mask.
> >
> > Fixes: c214410c47d6 ("bnxt_en: Add TPH support in BNXT driver")
> > Signed-off-by: Jakub Kicinski <[email protected]>
> > ---
> >  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > index 7513618793da..4a2a44ffe669 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > @@ -11859,14 +11859,14 @@ static void bnxt_free_irq(struct bnxt *bp)
> >
> >                 irq = &bp->irq_tbl[map_idx];
> >                 if (irq->requested) {
> > +                       bnxt_release_irq_notifier(irq);
> > +
>
> bnxt_release_irq_notifier() calls irq_set_affinity_notifier() to set
> the notifier to NULL.  But the call is not synchronous, right?  A
> pending notifier is still possible after irq_set_affinity_notifier()
> returns, right?

Nevermind.  It is synchronous so there is no issue.

Reviewed-by: Michael Chan <[email protected]>