Re: [PATCH net-next 00/15] pull request for net-next: batman-adv 2026-07-28

On 8/4/26 8:55 AM, Sven Eckelmann wrote:
> On Tuesday, 4 August 2026 04:19:20 CEST Jakub Kicinski wrote:
>> On Tue, 28 Jul 2026 15:39:03 +0200 Simon Wunderlich wrote:
>>> here is a minor bugfix/cleanup pull request of batman-adv to go into net-next.
>>
>> Can you look thru the Sashiko comments here (especially Medium+
>> severity)?
>>
>> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260728133918.643267-11-sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org
> 
> https://patchwork.open-mesh.org/bundle/ecsv/pu-main/
> 
> We were just waiting for a verdict. I am guessing it it a "no, will not 
> merge", correct?

Please be aware of net-next commit c82ff94592fb: the expectation is that
submitters reply proactively to AI review comments.

Specifically it would be helpful an evaluation of how critical is
problem reported and if it could safely addressed with a follow-up.

>> At a glance patch 14 does not inspire confidence. I guess patch 15
>> removes the worst part - but is there a real reason not to use locking?
> 
> In its current state, you would need spinlocks over larger (op-count) portions 
> of code in the hot-path. 

I'm not sure if the following is well known/helps, but performance wise
slightly lager critical regions are usually preferable to a larger
number of atomic operations,

/P