Re: [PATCH net-next v5 3/3] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver

On Tue, Aug 04, 2026 at 10:13:06AM +0300, Artem Shimko wrote:
> Hi Andrew,
> 
> On Tue, Aug 4, 2026 at 5:30 AM Andrew Lunn <[email protected]> wrote:
> 
> > Why 0.00 for one and 0.15ns for the other? PHY_INTERFACE_MODE_RGMII
> > means no delays.
> The 0x1 for TX is the hardware reset default from the datasheet, not
> a value we choose for RGMII mode.

Ah, please add a comment about that. It could be there is a minor
design issue within the PHY, and this is their workaround. So keep
it. A comment will then stop reviewers like me asking...

Part of producing a good patch is to try to think of all the questions
reviewers will ask, and answer them as part of the patch. Either
comments in the code, to text in the commit message.

	  Andrew