Re: [PATCH net-next v5 3/3] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver

Artem Shimko <[email protected]> Tue, 4 Aug 2026 17:05:21 +0300

Newsgroups	gmane.linux.kernel,gmane.linux.network,gmane.linux.drivers.devicetree
Message-ID	<CAOPX744zBT16jcTQHTPSDHv2rov1UPt=aTxECkrPK=7yG6FSQw@mail.gmail.com>

Hi Andrew,

On Tue, Aug 4, 2026 at 4:26 PM Andrew Lunn <[email protected]> wrote:

> Ah, please add a comment about that. It could be there is a minor
> design issue within the PHY, and this is their workaround. So keep
> it. A comment will then stop reviewers like me asking...
>
> Part of producing a good patch is to try to think of all the questions
> reviewers will ask, and answer them as part of the patch. Either
> comments in the code, to text in the commit message.
Will do. I'll add a comment explaining the hardware reset defaults
and update the commit message.

Thanks for the review!
---
Best regards,
Artem