Re: [RFC net-next v2 4/6] ptp: ocp: Validate EEPROM board IDs
Ahmad Byagowi <[email protected]> Tue, 4 Aug 2026 14:07:35 -0700
| Newsgroups | gmane.linux.drivers.i2c,gmane.linux.leds,gmane.linux.drivers.devicetree,gmane.linux.network,gmane.linux.kernel,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <[email protected]> |
Thanks for the review. Agreed, I will use the 12-character Fixes hash and split this safety fix from the feature series so it can target net. One detail about the suggested snprintf(): the size argument limits writes to buf, but a plain %s still scans bp->board_id for a NUL beyond its fixed 13-byte storage. I reused buf with a precision-bounded conversion instead: snprintf(buf, sizeof(buf), "%.*s", OCP_BOARD_ID_LEN, (const char *)bp->board_id); I have reduced this to a standalone net patch containing only the over-read fix. I will rebase the remaining R4006 and V9 feature series onto net-next after the fix reaches it. Thanks, Ahmad