Re: [PATCH net] net: ibm: emac: mal: fix NAPI locking
Simon Horman <[email protected]>
| Newsgroups | gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 11, 2026 at 03:08:13PM +0800, Runyu Xiao wrote:
> Since commit 413f0271f396 ("net: protect NAPI enablement with
> netdev_lock()"), napi_enable() and napi_disable() take netdev_lock().
>
> mal_register_commac() and mal_unregister_commac() call these helpers
> while holding mal->lock with interrupts disabled. In the unregister
> path, napi_disable() may also wait for polling to finish, while the poll
> completion path takes mal->lock.
>
> Take netdev_lock() before mal->lock, use the locked NAPI helpers, and
> drop mal->lock before napi_disable_locked().
>
> Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
> Cc: [email protected]
> Signed-off-by: Runyu Xiao <[email protected]>
Reviewed-by: Simon Horman <[email protected]>