Re: [PATCH net] 8139cp: fix Rx and Tx not being disabled in cp_suspend
Andrew Lunn <[email protected]>
| Newsgroups | gmane.linux.network,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 17, 2026 at 06:30:57AM +0200, Karl Mehltretter wrote:
> On QEMU rtl8139 model, frames that arrive while the interface is
> suspended still end up in the stack after resume. With pm_test=devices,
> which keeps devices suspended for 5s, 200 frames sent to interface
> during that time and 50 frames after resume, eth0 reports 113
> received frames.
>
> cp_suspend() is supposed to stop receiver and the transmitter, but
> the mask is wrong: (~RxOn | ~TxOn) is ~0, nothing is cleared and Cmd
> still reads 0x0d when cp_suspend() returns.
>
> Use ~(RxOn | TxOn) so both bits are actually cleared.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Karl Mehltretter <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Andrew