Re: [PATCH net-next v1 2/2] net: dsa: realtek: rtl8365mb: add EEE support

On Tue, Aug 18, 2026 at 02:22:29PM +0200, Oleksij Rempel wrote:
> On Mon, Aug 17, 2026 at 04:53:52PM +0200, Andrew Lunn wrote:
> > > +static int rtl8365mb_phylink_mac_enable_tx_lpi(struct phylink_config *config,
> > > +					       u32 timer, bool tx_clock_stop)
> > > +{
> > > +	/* The hardware manages LPI itself; there is no MAC-level LPI control.
> > > +	 * This callback only signals LPI awareness to phylink.
> > > +	 */
> > > +	return 0;
> > > +}
> > > +
> > > +static void rtl8365mb_phylink_mac_disable_tx_lpi(struct phylink_config *config)
> > > +{
> > > +}
> > > +
> > 
> > So what happens when i do:
> > 
> > ethtool --set-eee eth42 off
> > 
> > or
> > 
> > ethtool --set-eee eth42 tx-lpi on
> 
> In current implementation, with "tx-lpi off", the driver will return
> -EINVAL, "tx-lpi on" will be passed. It is aligned with KSZ driver.
> rtl8365mb_set_mac_eee() is used as filter.

Ah, good.

> Currently it is -EINVAL as in KSZ driver. If we will go with -EOPNOTSUPP
> then probably both drivers should follow it.

-EOPNOTSUPP would be better.  It is not an invalid configuration. This
 hardware cannot support it.

	Andrew