Re: Write and Submit Your First Kernel Patch
Kevyn-Alexandre Paré <[email protected]>
| Newsgroups | gmane.linux.newbie,gmane.linux.kernel.janitors,gmane.comp.version-control.git |
|---|---|
| Message-ID | <[email protected]> |
My mistake but I learn a lot from you guys! I should simply have done: ./scripts/checkpatch.pl --terse --patch 0001-Staging-comedi-driver-fix-coding-style.patch or ./scripts/checkpatch.pl --terse --patch 0001-Staging-comedi-driver-fix-coding-style.patch # Since --patch is the default! No warning to the output, I will change my blog thx again kap On Fri, Oct 23, 2009 at 4:58 PM, Junio C Hamano <[email protected]> wrote: > Daniel Barkalow <[email protected]> writes: > >> On Fri, 23 Oct 2009, Kevyn-Alexandre Paré wrote: >> >>> Just before I send my patch I got this error with: >>> ./scripts/checkpatch.pl --terse --file >>> 0001-Staging-comedi-driver-fix-coding-style.patch >> >> You're using checkpatch --file on a patch. I hope you don't intend your >> patch to be added to the kernel source as a file, but rather applied to >> the kernel source, changing other files. (I bet "gcc 0001-Staging*.patch" >> will get interesting errors, too...) The patch format adds a single >> character at the beginning of each line to say whether it's a addition, a >> deletion, or a context line, and the context lines are identified by a >> space character. This means that a blank context line consists of just >> this space character, which is therefore a trailing space. We get the same >> type of complaints when we have expected diff output in our test scripts. >> >> I'm kind of surprised that checkpatch doesn't completely blow up when it's >> expecting a source file and getting a patch (and maybe tell you what >> you've done). But that's the source of your errors, anyway. > > Ah, your analysis is correct. This is a usage error of checkpatch script > and there is nothing for us to worry about. > > Thanks; I also failed to spot --file option when I responded. > -- To unsubscribe from this list: send the line "unsubscribe linux-newbie" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs