Re: [PATCH v3 2/2 RESEND] checkpatch: warn on empty rust doc comments

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------6e9c0b4724622ca2873f2dc07faaadd38d4565d60e5b04cb49ae2ce015d54162
Content-Type: multipart/mixed;boundary=---------------------808725a943ee40242c6bec3ccc1f694e

-----------------------808725a943ee40242c6bec3ccc1f694e
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8






On Monday, September 30th, 2024 at 6:34 AM, Hridesh MG <[email protected]=
om> wrote:

> =


> =


> On Mon, Sep 30, 2024 at 8:11=E2=80=AFAM Patrick Miller paddymills@proton=
.me wrote:
> =


> > After the latest revision of my patch 1, I split the if statement so t=
hat
> > there is a parent check for rust files for future rust patch checks. S=
o,
> > this would perfectly fit within that block.
> > =


> > Do you want me to add your code and credit you in my patch?
> =


> =


> Please disregard my prior email, I had failed to CC everyone. Since
> the change is small I'm okay with adding it as part of your patch,
> please do add the Co-developed-by tag, thanks!
> =


> However, I was curious how conflicts like these are generally
> resolved. For example, if there are two large patchsets which conflict
> with each other, how does one ensure that they are compatible, and
> even if they are, how do the maintainers ensure that they are applied
> in the correct order?

2 changes that I am making to your patch as I merge it with mine (I tested=
 these)
  - Added a @fix option. I ran into this with my patch and was requested t=
o
      add it by a checkpatch maintainer
  - Revised your $prevrawline regex to check against existing blank lines =
as
      well as added blank lines (made the leading + optional). Otherwise I
      think the checkpatch would not match against a blank doc comment lin=
e
      added after an existing blank doc line.
-----------------------808725a943ee40242c6bec3ccc1f694e--

--------6e9c0b4724622ca2873f2dc07faaadd38d4565d60e5b04cb49ae2ce015d54162
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wnUEARYKACcFgmb8rRoJkJtRGrsur54RFiEE3KdIkSvUnCve801mm1Eauy6v
nhEAAMF4AQCLWQUOtp5+mg3j/o0JBoheDulcy8I2mrzVF4W5OOon7wEAyCOW
8Mi39DzrVpDEkeJEblr54UfE2ssXM7l+bTbw1g4=
=Z2AR
-----END PGP SIGNATURE-----


--------6e9c0b4724622ca2873f2dc07faaadd38d4565d60e5b04cb49ae2ce015d54162--