Re: [PATCH] Documentation: adopt new coding style of type-aware kmalloc-family

Manuel Ebner <[email protected]> Sat, 18 Apr 2026 12:45:19 +0200
Newsgroups gmane.linux.kernel.janitors,gmane.linux.newbie
Message-ID <[email protected]>
On Sat, 2026-04-18 at 13:27 +0300, Dan Carpenter wrote:
> On Sat, Apr 18, 2026 at 11:30:48AM +0200, Manuel Ebner wrote:
> > Would a patch like this one make sense?
> > I think i need help with the change log. Is there something to much or =
missing?
> >=20
> > ptr =3D kmalloc(sizeof(*ptr), gfp);
> > =C2=A0-> ptr =3D kmalloc_obj(*ptr, gfp);
> >=20
> > =C2=A0This one is done. The ones below are not done yet.
> >=20
> > ptr =3D kmalloc(sizeof(struct some_obj_name), gfp);
> > =C2=A0-> ptr =3D kmalloc_obj(*ptr, gfp);
> > ptr =3D kzalloc(sizeof(*ptr), gfp);
> > =C2=A0> ptr =3D kzalloc_obj(*ptr, gfp);
> > ptr =3D kmalloc_array(count, sizeof(*ptr), gfp);
> > =C2=A0-> ptr =3D kmalloc_objs(*ptr, count, gfp);
> > ptr =3D kcalloc(count, sizeof(*ptr), gfp);
> > =C2=A0-> ptr =3D kzalloc_objs(*ptr, count, gfp);
> >=20
> > change log:
> > [PATCH] Documentation: adopt new coding style of type-aware kmalloc-fam=
ily
> >=20
> > Update the documentation to reflect new type-aware kmalloc-family as
> > suggested in commit 2932ba8d9c99 ("slab: Introduce kmalloc_obj() and fa=
mily")
> >=20
> > ptr =3D kmalloc(sizeof(*ptr), gfp);
> > =C2=A0-> ptr =3D kmalloc_obj(*ptr, gfp);
> >=20
> > Signed-off-by: Manuel Ebner <[email protected]>
>=20
> Yeah.=C2=A0 Fix up the commit message and that could probably be merged
> through the documentation tree.=C2=A0

how do i fix the commit message?
 what's even the issue?
 is the one-line-message ok?
=20

> Probably no need to split it up
> by subsystem, but you should CC the affected subsystems.

Thanks, i struggled with who to send it to.

> regards,
> dan carpener

can i add
Reviewed-by: Dan Carpenter <[email protected]>
?

Thanks,
Manuel