Re: [PATCH v2] nfsd: release OPEN-decoded posix ACLs via op_release

On 6/1/26 6:41 AM, Jeff Layton wrote:
> On Mon, 2026-06-01 at 11:06 +1000, NeilBrown wrote:

>> I think this patch is good, but I think it would be even better if the
>> ->op_release() call were moved out of nfsd4_encode_operation() and
>> places after this if-else.  Then there would be only one call-site in a
>> fairly obviously-correct place.
>> But:
>>   Reviewed-by: NeilBrown <neil-+NVA1uvv1dVBDLzU/[email protected]>
>> for if you just want to stick with this version.
>>
>> Thanks,
>> NeilBrown
>>
> 
> I like that idea.
> 
> I'll be testing a pile of other patches today anyway, so I'll make this
> change and test it alongside the rest.
> 
> Chuck, you can either take this one and I'll do a cleanup patch along
> the lines of what Neil suggests, or I can send a v3.

v3 sounds fine.


-- 
Chuck Lever