[PATCH 2/2] xprtrdma: Remove tautological I2 assertion in rpcrdma_reply_put
Chuck Lever <[email protected]>
| Newsgroups | gmane.linux.drivers.rdma,gmane.linux.nfs |
|---|---|
| Message-ID | <[email protected]> |
From: Chuck Lever <[email protected]> rpcrdma_reply_put() sets req->rl_reply to NULL when it is non-NULL, and skips the block when it is already NULL. The WARN_ON_ONCE(req->rl_reply) that follows can never fire because both paths leave rl_reply NULL. Remove the dead assertion and its comment. Signed-off-by: Chuck Lever <[email protected]> --- net/sunrpc/xprtrdma/verbs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index da2c6fa44154..92c691d2521f 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1259,10 +1259,6 @@ void rpcrdma_reply_put(struct rpcrdma_buffer *buffers, struct rpcrdma_req *req) req->rl_reply = NULL; rpcrdma_rep_put(buffers, rep); } - /* I2: rl_reply NULL after the put closes the - * 'rep on rb_free_reps still referenced by req' window. - */ - WARN_ON_ONCE(req->rl_reply); } /** -- 2.54.0