Re: [PATCH rdma-next v6] RDMA: Change capability fields in ib_device_attr from int to u32
Erni Sri Satya Vennela <[email protected]>
| Newsgroups | gmane.linux.drivers.rdma,gmane.linux.kernel,gmane.linux.scsi.target.devel,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.linux.nfs,gmane.linux.network |
|---|---|
| Message-ID | <aiPDLFM0xYlDYQFc@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> |
On Tue, Jun 02, 2026 at 12:21:58PM +0300, Andy Shevchenko wrote: > On Mon, Jun 01, 2026 at 08:51:40AM -0700, Bart Van Assche wrote: > > On 6/1/26 2:25 AM, Erni Sri Satya Vennela wrote: > > ... > > > > - sdev->srq_size = min(srpt_srq_size, sdev->device->attrs.max_srq_wr); > > > + sdev->srq_size = min_t(u32, srpt_srq_size, sdev->device->attrs.max_srq_wr); > > > > min_t() shouldn't be used if there is an alternative available. For the > > SRP drivers, please make sure that both arguments of min() are unsigned > > instead of using min_t(). > > Ah, I just answered in similar way against v5. I also mentioned clamp() there. Yes. I'll be incorporating those changes in the next version. - Vennela > > -- > With Best Regards, > Andy Shevchenko >