Re: [PATCH 0/4] nfs: remove the fileid field from struct nfs_inode
"Anna Schumaker" <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.nfs,gmane.linux.documentation |
|---|---|
| Message-ID | <[email protected]> |
Hi Jeff, On Sat, Jun 20, 2026, at 9:06 PM, Jeff Layton wrote: > On Tue, 2026-05-12 at 12:12 -0400, Jeff Layton wrote: >> v7.1-rc1 contains patches to make inode->i_ino to be a u64. With this >> change, there is no need to keep a separate "fileid" field in struct >> nfs_inode. >> >> This patchset eliminiates that field, and the inode number hashing >> machinery that is no longer needed. This shaves 8 bytes off of each >> nfs_inode. >> >> Trond/Anna: please consider this for v7.2. >> >> Assisted-by: Claude:claude-opus-4-6 >> Signed-off-by: Jeff Layton <[email protected]> >> --- >> Jeff Layton (4): >> nfs: store the full NFS fileid in inode->i_ino >> nfs: remove nfs_compat_user_ino64() and deprecate enable_ino64 >> nfs: replace NFS_FILEID() and nfsi->fileid with inode->i_ino >> nfs: remove fileid field from struct nfs_inode >> >> Documentation/admin-guide/kernel-parameters.txt | 7 -- >> fs/nfs/dir.c | 4 +- >> fs/nfs/export.c | 6 +- >> fs/nfs/filelayout/filelayout.c | 4 +- >> fs/nfs/flexfilelayout/flexfilelayout.c | 6 +- >> fs/nfs/inode.c | 87 +++++++++---------------- >> fs/nfs/nfs4proc.c | 4 +- >> fs/nfs/nfs4trace.h | 79 ++++++++++------------ >> fs/nfs/nfstrace.h | 84 ++++++++++++------------ >> fs/nfs/pagelist.c | 2 +- >> fs/nfs/pnfs.c | 2 +- >> fs/nfs/unlink.c | 2 +- >> fs/nfs/write.c | 2 +- >> include/linux/nfs_fs.h | 25 ------- >> 14 files changed, 123 insertions(+), 191 deletions(-) >> --- >> base-commit: 5d6919055dec134de3c40167a490f33c74c12581 >> change-id: 20260512-nfsino-1f9a8ca2f3ed >> >> Best regards, > > Ping? > > i just noticed that this never made v7.2. Maybe consider for v7.3? These are actually the first four patches in my linux-next branch for the pull request I'm planning on sending (hopefully) later today. Anna > -- > Jeff Layton <[email protected]>