Re: [PATCH 1/1] lockd: fix GRANTED_MSG handling
"Chuck Lever" <[email protected]>
| Newsgroups | gmane.linux.nfs |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jun 25, 2026, at 5:18 PM, Olga Kornievskaia wrote:
> GRANTED_MSG is a server-to-client callback, so it runs on the client,
> where nfsd never registers nlmsvc_ops. The nlm4svc_lookup_host()/
> nlm3svc_lookup_host() helpers are for the server-side request handlers
> (TEST/LOCK/CANCEL/UNLOCK), which reach nlmsvc_ops->fopen and must
> reject requests when nfsd isn't running. GRANTED_MSG only calls
> nlmclnt_grant(). Instead, of calling nlm4svc_lookup_host()/
> nlm3svc_lookup_host() (which results in a client failing a GRANTED_MSG
> call) call nlmsvc_lookup_host.
>
> Fixes: 62721885e861 ("lockd: Use xdrgen XDR functions for the NLMv4
> GRANTED_MSG procedure")
> Fixes: 6c534ad999b6 ("lockd: Use xdrgen XDR functions for the NLMv3
> GRANTED_MSG procedure")
> Signed-off-by: Olga Kornievskaia <[email protected]>
The fix LGTM.
Looking at this now, I see the patch targets two distinct
stable kernels. Therefore IMO this does actually need to be
two separate patches. I will split the patch when I apply
it to nfsd-testing.
--
Chuck Lever