[PATCH 1/9] NFSD: Make "stats.h" self-contained
Chuck Lever <[email protected]>
| Newsgroups | gmane.linux.nfs |
|---|---|
| Message-ID | <[email protected]> |
The inline helpers in fs/nfsd/stats.h dereference struct nfsd_net and struct svc_export, yet the header includes neither "netns.h" nor "export.h", where those types are defined. Each helper therefore compiles only when its translation unit has already pulled in both headers ahead of "stats.h" -- a hidden ordering requirement that has to be honored at every include site. Include "netns.h" and "export.h" from "stats.h" directly so the header stands on its own, and no consumer has to order its includes to satisfy it. Signed-off-by: Chuck Lever <[email protected]> --- fs/nfsd/stats.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nfsd/stats.h b/fs/nfsd/stats.h index e4efb0e4e56d..87736b7fbf28 100644 --- a/fs/nfsd/stats.h +++ b/fs/nfsd/stats.h @@ -10,6 +10,9 @@ #include <uapi/linux/nfsd/stats.h> #include <linux/percpu_counter.h> +#include "export.h" +#include "netns.h" + struct proc_dir_entry *nfsd_proc_stat_init(struct net *net); void nfsd_proc_stat_shutdown(struct net *net); -- 2.54.0