Re: [PATCH 0/6] NFSv4-related tidying
Jeff Layton <[email protected]> Mon, 20 Jul 2026 07:57:41 -0400
| Newsgroups | gmane.linux.nfs |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 2026-07-17 at 14:41 -0400, Chuck Lever wrote:
> Now that Neil's vfs_create() rework has been applied to nfsd-testing,
> I feel more comfortable sending along more of these clean-up patches.
> The goal is to reduce dependencies on single large individual headers
> that pull in items that are irrelevant in many cases.
>
> Chuck Lever (6):
> NFSD: Move XDR encoding helpers out of xdr4.h
> NFSD: Move pre-xdr'ed status codes out of nfsd.h
> NFSD: Remove two unused NFSv4 constants
> NFSD: Relocate NFSv4-internal constants to state.h
> NFSD: Evacuate NFSv4 entry-point prototypes from nfsd.h
> NFSD: Move nfsd_v4client() out of nfsd.h
>
> fs/nfsd/blocklayout.c | 1 +
> fs/nfsd/blocklayoutxdr.c | 11 ++
> fs/nfsd/export.c | 2 +
> fs/nfsd/filecache.c | 1 +
> fs/nfsd/flexfilelayout.c | 1 +
> fs/nfsd/flexfilelayoutxdr.c | 1 +
> fs/nfsd/lockd.c | 1 +
> fs/nfsd/nfs2acl.c | 1 +
> fs/nfsd/nfs3acl.c | 1 +
> fs/nfsd/nfs3proc.c | 1 +
> fs/nfsd/nfs3xdr.c | 1 +
> fs/nfsd/nfs4acl.c | 1 +
> fs/nfsd/nfs4callback.c | 1 +
> fs/nfsd/nfs4ctl.h | 83 ++++++++++++
> fs/nfsd/nfs4idmap.c | 1 +
> fs/nfsd/nfs4layouts.c | 1 +
> fs/nfsd/nfs4proc.c | 2 +
> fs/nfsd/nfs4recover.c | 1 +
> fs/nfsd/nfs4state.c | 2 +
> fs/nfsd/nfs4xdr.c | 93 +++++++++++++
> fs/nfsd/nfscache.c | 1 +
> fs/nfsd/nfsctl.c | 2 +
> fs/nfsd/nfsd.h | 236 +--------------------------------
> fs/nfsd/{nfsd.h => nfserr.h} | 248 +----------------------------------
> fs/nfsd/nfsfh.c | 1 +
> fs/nfsd/nfsproc.c | 1 +
> fs/nfsd/nfssvc.c | 8 ++
> fs/nfsd/nfsxdr.c | 1 +
> fs/nfsd/state.h | 19 +++
> fs/nfsd/vfs.c | 2 +
> fs/nfsd/xdr4.h | 139 --------------------
> 31 files changed, 250 insertions(+), 615 deletions(-)
> create mode 100644 fs/nfsd/nfs4ctl.h
> copy fs/nfsd/{nfsd.h => nfserr.h} (50%)
LGTM
Reviewed-by: Jeff Layton <[email protected]>