Re: [PATCH 1/2] nfsd: fix type mismatch and explain host-endian xdr buffer usage

On Mon, 2026-08-03 at 11:32 -0400, Chuck Lever wrote:
>=20
> On Mon, Aug 3, 2026, at 10:49 AM, Jeff Layton wrote:
> > sparse flagged this type mismatch. Also the xdr buffer usage is a bit
> > non-standard, so explain what we're doing and why.
> >=20
> > Fixes: 4b64b811f368 ("nfsd: add notification handlers for dir events")
> > Reported-by: kernel test robot <[email protected]>
> > Closes:=20
> > https://lore.kernel.org/oe-kbuild-all/[email protected]=
om/
> > Signed-off-by: Jeff Layton <[email protected]>
> > ---
> >  fs/nfsd/nfs4xdr.c | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index a47eb544b99f..5cbb4a415384 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> > @@ -4383,13 +4383,18 @@ nfsd4_setup_notify_entry4(struct notify_entry4=
=20
> > *ne, struct xdr_stream *xdr,
> >  	struct path path =3D nf->nf_file->f_path;
> >  	struct nfsd4_fattr_args args =3D { };
> >  	const u32 *reqmask;
> > -	uint32_t *attrmask;
> > +	u32 *attrmask;
> >  	__be32 status;
> >  	bool parent;
> >  	int ret;
> >=20
> > -	/* Reserve space for attrmask */
> > -	attrmask =3D xdr_reserve_space(xdr, 3 * sizeof(uint32_t));
> > +	/*
> > +	 * attrmask is the host-order bmval[3] that nfsd4_encode_attr_vals()
> > +	 * consumes and that ne_attrs.attrmask.element points at. It must
> > +	 * outlive this call, so steal a few words from the xdr stream to hol=
d
> > +	 * it.
> > +	 */
> > +	attrmask =3D (u32 *)xdr_reserve_space(xdr, 3 * sizeof(*attrmask));
> >  	if (!attrmask)
> >  		return false;
>=20
> I still don't understand what's going on. "Steal a few words to hold it"
> sounds like you're trying to avoid a kmalloc call. Is this code reserving
> space in the XDR stream, or isn't it? If it is, then accessing those byte=
s
> has to be done with a big-endian pointer, the same way it is done at ever=
y
> other xdr_reserve_space() call site. Storing host-order bytes that are no=
t
> part of an opaque into an XDR stream is just... wrong.
>=20
> If you're doing the usual "reserve and backfill the encoded data later"
> dance, then spell it the way everyone else does so us poor human readers
> can recognize that's what's going on.
>=20

It's using a small piece of the xdr buffer (3 32-bit words) to hold the
host-endian bitmap fields that will later be encoded into the stream
when the encoding is actually done.

This piece is not accessed by anything else and there is plenty of room
in the buffer, so I don't see the issue here. Can you elaborate on why
you feel that this is a problem?
=20
Certainly we could do this with yet another set of separate
allocations, but I'm not clear on how we'd track them to free them.
Each notify_entry4 gets a separate bitmap, so we'd need more than one.

--=20
Jeff Layton <[email protected]>