Re: NGPT 2.0.2 RELEASED

Hello!

On Sun, Sep 22, 2002 at 10:58:47PM +0200, Peter Waechtler wrote:
> Am Sonntag den, 22. September 2002, um 14:45, schrieb Marc-Christian 
> Petersen:
> > On Thursday 12 September 2002 03:57, Bill Abt wrote:
> >> http://oss.software.ibm.com/developerworks/opensource/pthreads
> > err, am I silly or are 2.0.1 and 2.0.2 exactly the same?
You aren't and the kernel patches are exactly the same.

> > Peter Waechtler stated that the kernel patch is bigger than nessecary
> > (http://www.moses.uklinux.net/patches/dontdiff) but non of the mentioned
> > files are in the patch?
> > Am I drunken? :)
> Perhaps :)
He's not! The unrelated SCSI driver patch is in the patch but futex.c was
not updated in any way.

> my comment was regarding the kernel patches:
> -rw-r--r--    1 peewee   peewee      18180 Aug 19 15:07 patch-
> futex-2.4.19-2.0.1
> -rw-r-----    1 peewee   peewee      18181 Sep 12 17:55 patch-
> futex-2.4.19-2.0.2
> the one char diff is "!" - but this is a cleaned patch - the hunks
> of the scsi header file is removed
This may be the state on your hard disk but all the rest of us sees only the
directory
http://www-124.ibm.com/developerworks/opensource/pthreads/download/stable/kernel/
with the 2 identical files
http://www-124.ibm.com/developerworks/opensource/pthreads/download/stable/kernel/patch-futex-2.4.19-2.0.2.gz
http://www-124.ibm.com/developerworks/opensource/pthreads/download/stable/kernel/patch-futex-2.4.19-2.0.1.gz
BTW, gzip includes the original file name of the uncompressed file in the
header, so we can see there the original file name "patch-futex-2.4.19-2.0.1".

So I better attach the "!" correction to make shared conditional variables work.

Bye, Uwe

-- 
Dr. Uwe Girlich              email: [email protected]
Philosys Software GmbH       www: www.philosys.de
Edisonstrasse 6              phone: +49 89 321407-44
D-85716 Unterschleissheim    fax: +49 89 321407-12

--- linux-2.4.19-rc1-ngpt-2.0.0/kernel/futex.c.orig	Wed Jul 10 16:07:09 2002
+++ linux-2.4.19-rc1-ngpt-2.0.0/kernel/futex.c	Wed Jul 10 16:07:34 2002
@@ -238,7 +238,7 @@
 
 	poll_wait(filp, &q->waiters, wait);
 	spin_lock(&futex_lock);
-	if (!list_empty(&q->list))
+	if (list_empty(&q->list))
 		ret = POLLIN | POLLRDNORM;
 	spin_unlock(&futex_lock);