Re: And another thing...

On 30/07/14 23:26, Maynard Johnson wrote:
> On 07/30/2014 12:06 PM, Andrew Haley wrote:
>> I kept getting  "now trying to kill convert pid..." error messages.
>> Turns out that there is only a 5s wait for the daemon to terminate,
>> which is nowhere near long enough if you have lot of symbols.

> Andrew, what were you profiling when you saw this? 

The HotSpot JVM.

> Unfortunately, the term "convert" is used for two different tasks in
> the internal workings of operf.  First, we have the
> perf_events-formatted data from the kernel being converted to
> oprofile sample file format.  Second, we run the opjitconv to
> convert any JVM jitdump files to ELF files.  It is the latter task
> for which you are seeing this message. I agree the fixed time limit
> is not ideal.  I'm guessing you are profiling lots of JVMs to see
> this message.

No, just the one: it takes a long time.

> When profiling a large busy system, the conversion of perf-format
> data to oprofile sample file format can cause noticeable overhead,
> and you might want to think about using the --lazy-conversion option
> in that case.
>
> As for the patch, I'm not sure I want to change one hard-coded time
> limit for another. I'll give this some thought.

Whatever you do, please give an error message that tells the user what
to do.  The hard time limit makes no sense to me.

Andrew.

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk