Re: [PATCH] Remove opcontrol, as well as GUI and processor models dependent on it

Maynard Johnson <[email protected]>
Newsgroups gmane.linux.oprofile
Message-ID <[email protected]>
On 08/05/2014 03:26 PM, Maynard Johnson wrote:
> 
[snip]
Patch committed.

-Maynard
> Remove opcontrol and the GUI and processor models dependent on it
> 
> The opcontrol-based profiler has been deprecated since 0.9.8, and it is now
> being removed for release 1.0.  At the same time, we must remove the GUI
> component (i.e., oprof_start tool) which currently only supports opcontrol.
> And with the removal of the GUI, oprofile no longer has the need for QT, so
> so relevant changes were made in configuration.ac and the m4/qt.m4 file removed.
> 
>   Note: There has been some discussion off and on over the past year or so
>   about modernizing oprof_start and adding operf support to it, but there has
>   not been enough interest in the tool to get this done.
> 
> Certain older architectures and processor types have been supported only by
> opcontrol, so this patch removes all files and references relating to them.
> The affected architectures/processor types are:
> 
>    Arch avr32
>    Arch ia64
>    Processor model IBM Cell
>    Processor model P.A. Semi PA6T
>    RTC
> 
> OProfile users still running on any of these affected systems should not upgrade to
> OProfile release 1.0.
> 
> Finally, various code and doc touch-ups were done to remove references to opcontrol
> and the various parts of the opcontrol-based profiler.
> 
> Signed-off-by: Maynard Johnson <[email protected]>
> ---
>  Makefile.am                               |    2 -
>  README                                    |   25 +-
>  configure.ac                              |   80 -
>  daemon/.gitignore                         |    4 -
>  daemon/Makefile.am                        |   57 -
>  daemon/init.c                             |  374 -----
>  daemon/liblegacy/.gitignore               |    4 -
>  daemon/opd_anon.c                         |  228 ---
>  daemon/opd_anon.h                         |   54 -
>  daemon/opd_cookie.c                       |  210 ---
>  daemon/opd_cookie.h                       |   39 -
>  daemon/opd_events.c                       |  189 ---
>  daemon/opd_events.h                       |   47 -
>  daemon/opd_extended.c                     |  195 ---
>  daemon/opd_extended.h                     |   94 --
>  daemon/opd_ibs.c                          |  837 -----------
>  daemon/opd_ibs.h                          |  133 --
>  daemon/opd_ibs_macro.h                    |  397 -----
>  daemon/opd_ibs_trans.c                    |  634 --------
>  daemon/opd_ibs_trans.h                    |   35 -
>  daemon/opd_interface.h                    |   48 -
>  daemon/opd_kernel.c                       |  229 ---
>  daemon/opd_kernel.h                       |   43 -
>  daemon/opd_mangling.c                     |  213 ---
>  daemon/opd_mangling.h                     |   33 -
>  daemon/opd_perfmon.c                      |  522 -------
>  daemon/opd_perfmon.h                      |  106 --
>  daemon/opd_pipe.c                         |   99 --
>  daemon/opd_pipe.h                         |   45 -
>  daemon/opd_printf.h                       |   37 -
>  daemon/opd_sfile.c                        |  751 ----------
>  daemon/opd_sfile.h                        |  119 --
>  daemon/opd_spu.c                          |  176 ---
>  daemon/opd_stats.c                        |   92 --
>  daemon/opd_stats.h                        |   32 -
>  daemon/opd_trans.c                        |  354 -----
>  daemon/opd_trans.h                        |   86 --
>  daemon/oprofiled.c                        |  532 -------
>  daemon/oprofiled.h                        |   69 -
>  doc/Makefile.am                           |    2 -
>  doc/opannotate.1.in                       |   15 +-
>  doc/oparchive.1.in                        |   17 +-
>  doc/opcontrol.1.in                        |  198 ---
>  doc/operf.1.in                            |   18 +-
>  doc/opgprof.1.in                          |   13 +-
>  doc/ophelp.1.in                           |    3 -
>  doc/opimport.1.in                         |    4 +-
>  doc/opreport.1.in                         |   15 +-
>  doc/oprof_start.1.in                      |   43 -
>  doc/oprofile.1.in                         |   22 -
>  doc/oprofile.xml                          | 1177 +++------------
>  events/Makefile.am                        |    8 -
>  events/avr32/events                       |   27 -
>  events/avr32/unit_masks                   |    4 -
>  events/ia64/ia64/events                   |    3 -
>  events/ia64/ia64/unit_masks               |    4 -
>  events/ia64/itanium/events                |    5 -
>  events/ia64/itanium/unit_masks            |    4 -
>  events/ia64/itanium2/events               |  267 ----
>  events/ia64/itanium2/unit_masks           |  465 ------
>  events/ppc64/cell-be/events               |  517 -------
>  events/ppc64/cell-be/unit_masks           |  137 --
>  events/ppc64/ibm-compat-v1/event_mappings |   82 --
>  events/ppc64/ibm-compat-v1/events         |   91 --
>  events/ppc64/ibm-compat-v1/unit_masks     |    9 -
>  events/ppc64/pa6t/event_mappings          |   48 -
>  events/ppc64/pa6t/events                  |   52 -
>  events/ppc64/pa6t/unit_masks              |    4 -
>  events/rtc/events                         |    3 -
>  events/rtc/unit_masks                     |    4 -
>  gui/.gitignore                            |    7 -
>  gui/Makefile.am                           |   43 -
>  gui/oprof_start.cpp                       | 1094 --------------
>  gui/oprof_start.h                         |  170 ---
>  gui/oprof_start_config.cpp                |  104 --
>  gui/oprof_start_config.h                  |   56 -
>  gui/oprof_start_main.cpp                  |   37 -
>  gui/oprof_start_util.cpp                  |  324 -----
>  gui/oprof_start_util.h                    |   39 -
>  gui/ui/.gitignore                         |    6 -
>  gui/ui/Makefile.am                        |   24 -
>  gui/ui/oprof_start.base.ui                | 1190 ---------------
>  libop/Makefile.am                         |    2 -
>  libop/op_alloc_counter.c                  |   61 +-
>  libop/op_config.c                         |   11 -
>  libop/op_config.h                         |   31 -
>  libop/op_cpu_type.c                       |   69 +-
>  libop/op_cpu_type.h                       |   35 +-
>  libop/op_events.c                         |   82 +-
>  libop/op_events.h                         |   10 -
>  libop/op_get_interface.c                  |   29 -
>  libop/op_interface.h                      |   87 --
>  libop/op_parse_event.c                    |   11 -
>  libop/op_xml_events.c                     |   15 -
>  libop/tests/cpu_type_tests.c              |    4 -
>  libpp/op_header.cpp                       |   26 +-
>  libpp/profile_spec.cpp                    |    5 +-
>  m4/Makefile.am                            |    1 -
>  m4/cellspubfdsupport.m4                   |   52 -
>  m4/qt.m4                                  |  225 ---
>  opjitconv/create_bfd.c                    |    1 -
>  opjitconv/jitsymbol.c                     |    1 -
>  opjitconv/opjitconv.c                     |    7 +-
>  opjitconv/opjitconv.h                     |    8 +
>  opjitconv/parse_dump.c                    |    1 -
>  pe_counting/ocount.cpp                    |   12 +-
>  pe_profiling/operf.cpp                    |   10 +-
>  pp/common_option.cpp                      |    2 +-
>  pp/oparchive_options.cpp                  |    4 +-
>  utils/Makefile.am                         |    1 -
>  utils/opcontrol                           | 2252 -----------------------------
>  utils/ophelp.c                            |   80 +-
>  112 files changed, 344 insertions(+), 16370 deletions(-)
>  delete mode 100644 daemon/.gitignore
>  delete mode 100644 daemon/Makefile.am
>  delete mode 100644 daemon/init.c
>  delete mode 100644 daemon/liblegacy/.gitignore
>  delete mode 100644 daemon/opd_anon.c
>  delete mode 100644 daemon/opd_anon.h
>  delete mode 100644 daemon/opd_cookie.c
>  delete mode 100644 daemon/opd_cookie.h
>  delete mode 100644 daemon/opd_events.c
>  delete mode 100644 daemon/opd_events.h
>  delete mode 100644 daemon/opd_extended.c
>  delete mode 100644 daemon/opd_extended.h
>  delete mode 100644 daemon/opd_ibs.c
>  delete mode 100644 daemon/opd_ibs.h
>  delete mode 100644 daemon/opd_ibs_macro.h
>  delete mode 100644 daemon/opd_ibs_trans.c
>  delete mode 100644 daemon/opd_ibs_trans.h
>  delete mode 100644 daemon/opd_interface.h
>  delete mode 100644 daemon/opd_kernel.c
>  delete mode 100644 daemon/opd_kernel.h
>  delete mode 100644 daemon/opd_mangling.c
>  delete mode 100644 daemon/opd_mangling.h
>  delete mode 100644 daemon/opd_perfmon.c
>  delete mode 100644 daemon/opd_perfmon.h
>  delete mode 100644 daemon/opd_pipe.c
>  delete mode 100644 daemon/opd_pipe.h
>  delete mode 100644 daemon/opd_printf.h
>  delete mode 100644 daemon/opd_sfile.c
>  delete mode 100644 daemon/opd_sfile.h
>  delete mode 100644 daemon/opd_spu.c
>  delete mode 100644 daemon/opd_stats.c
>  delete mode 100644 daemon/opd_stats.h
>  delete mode 100644 daemon/opd_trans.c
>  delete mode 100644 daemon/opd_trans.h
>  delete mode 100644 daemon/oprofiled.c
>  delete mode 100644 daemon/oprofiled.h
>  delete mode 100644 doc/opcontrol.1.in
>  delete mode 100644 doc/oprof_start.1.in
>  delete mode 100644 events/avr32/events
>  delete mode 100644 events/avr32/unit_masks
>  delete mode 100644 events/ia64/ia64/events
>  delete mode 100644 events/ia64/ia64/unit_masks
>  delete mode 100644 events/ia64/itanium/events
>  delete mode 100644 events/ia64/itanium/unit_masks
>  delete mode 100644 events/ia64/itanium2/events
>  delete mode 100644 events/ia64/itanium2/unit_masks
>  delete mode 100644 events/ppc64/cell-be/events
>  delete mode 100644 events/ppc64/cell-be/unit_masks
>  delete mode 100644 events/ppc64/ibm-compat-v1/event_mappings
>  delete mode 100644 events/ppc64/ibm-compat-v1/events
>  delete mode 100644 events/ppc64/ibm-compat-v1/unit_masks
>  delete mode 100644 events/ppc64/pa6t/event_mappings
>  delete mode 100644 events/ppc64/pa6t/events
>  delete mode 100644 events/ppc64/pa6t/unit_masks
>  delete mode 100644 events/rtc/events
>  delete mode 100644 events/rtc/unit_masks
>  delete mode 100644 gui/.gitignore
>  delete mode 100644 gui/Makefile.am
>  delete mode 100644 gui/oprof_start.cpp
>  delete mode 100644 gui/oprof_start.h
>  delete mode 100644 gui/oprof_start_config.cpp
>  delete mode 100644 gui/oprof_start_config.h
>  delete mode 100644 gui/oprof_start_main.cpp
>  delete mode 100644 gui/oprof_start_util.cpp
>  delete mode 100644 gui/oprof_start_util.h
>  delete mode 100644 gui/ui/.gitignore
>  delete mode 100644 gui/ui/Makefile.am
>  delete mode 100644 gui/ui/oprof_start.base.ui
>  delete mode 100644 libop/op_get_interface.c
>  delete mode 100644 libop/op_interface.h
>  delete mode 100644 m4/cellspubfdsupport.m4
>  delete mode 100644 m4/qt.m4
>  delete mode 100755 utils/opcontrol
> 
[snip]
> 


------------------------------------------------------------------------------
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.