Re: [PATCH] OProfile 1.0 test suite, Fix calls to opcontrol
Maynard Johnson <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
On 08/07/2014 09:46 AM, Maynard Johnson wrote: > On 08/06/2014 12:57 PM, Carl Love wrote: >> Maynard: >> >> The following patch is for the OProfile 1.0 test suite release. It >> fixes the test suite to handle the absence of opcontrol command for the >> 1.0 and newer releases. > Thanks, Carl. The patch looks good and seems to work well with my opcontrol-removal > patch posted yesterday. After I've committed, the opcontrol-removal patch, I'll > commit your testsuite patch. Patch committed. Thanks. -Maynard > > -Maynard >> >> Carl Love >> >> ----------------------------------------------------------------------------- >> >> OProfile 1.0 test suite, Fix calls to opcontrol >> >> Operf and ocount make calls to opcontrol to make sure the daemon is shut down, >> clear out any existing samples etc. Starting with version 1.0, the >> opcontrol command no longer exists. This patch will ensure that operf and >> ocount do not make any calls to opcontrol if the command does not exist. >> >> The opcontrol test suite currently checks if opcontrol exists and exits if >> it doesn't exist. This test suite needs just to set the opcontrol_installed >> variable to 0 in the case that opcontrol isn't installed so the exit routine >> will not call opcontrol --deinit. >> >> Signed-off-by: Carl Love <[email protected]> >> --- >> testsuite/config/unix.exp | 3 +- >> testsuite/lib/op_util.exp | 14 +++++++++ >> testsuite/oprofile-ocount/ocount-run.exp | 21 ++++++++++++- >> .../oprofile-opcontrol/oprofile-opcontrol-run.exp | 34 ++++++++++----------- >> testsuite/oprofile-operf/oprofile-operf-run.exp | 35 ++++++++++++++++++---- >> 5 files changed, 81 insertions(+), 26 deletions(-) [snip] ------------------------------------------------------------------------------