Re: [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER

Hi Robert,

> I also don't see a reason, why you don't want to support oprofile NMI
> timer. Is there any?

I couldn't come up with a case where it would be a benefit to us. We
roll out PMU support for a new CPU early so that the kernel and tools
support it when we GA. On the other hand adding oprofile NMI support
will put pressure on us to add more test cases.

> If you don't want NMI_TIMER being enabled, then (order of preference):
> 
>  * disable it with oprofile (OPROFILE dependency needed for
>    NMI_TIMER), or
> 
>  * make the default value for NMI_TIMER !PPC64 and add a prompt to let
>    the user select/deselect it, or
> 
>  * disable OPROFILE_NMI_TIMER by adding a !PPC64 dependency.

I'll rework and resubmit. Thanks.

Anton
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev