Re: [PATCH] DATA_CACHE_MISSES unit mask testsuite fix for AMD generic
William Cohen <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
Hi Micahel, Thanks for the patch. It has been pushed to the upstream oprofile-test git repository. -Will On 03/27/2015 12:48 PM, Michael Petlan wrote: > Resending the patch again after fixing it.. > -- > The default unit mask for the event DATA_CACHE_MISSES on AMD family 15h > CPUs is 0x1 instead of 0x0, which is common for other AMD CPUs. When the > "athlon" test event table is used on an AMD family 15h machine, the test > fails. A slightly modified event table for AMD family 15h has been added > in order to fix the issue. > > Signed-off-by: Michael Petlan <[email protected]> > -- > diff --git a/testsuite/lib/op_events.exp b/testsuite/lib/op_events.exp > index b71811c..70acace 100644 > --- a/testsuite/lib/op_events.exp > +++ b/testsuite/lib/op_events.exp > @@ -210,6 +210,18 @@ set op_event_table(athlon) \ > } \ > } > > +set op_event_table(amd_generic) \ > + { \ > + { \ > + {0 CPU_CLK_UNHALTED 0 500000} \ > + {1 DATA_CACHE_ACCESSES 0 500000} \ > + } \ > + { \ > + {0 DATA_CACHE_ACCESSES 0 500000} \ > + {1 DATA_CACHE_MISSES 1 500000} \ > + } \ > + } > + > set op_event_table(p4) \ > { \ > { \ > @@ -712,8 +724,8 @@ proc select_cpu_events {cpu_name} { > x86-64/family14h {set type athlon} > AMD64_family14h {set type athlon} > 65 {set type athlon} > - x86-64/family15h {set type athlon} > - AMD64_family15h {set type athlon} > + x86-64/family15h {set type amd_generic} > + AMD64_family15h {set type amd_generic} > 66 {set type arch_perf} > i386/westmere {set type arch_perf} > Intel_Westmere_microarchitecture {set type arch_perf} > @@ -761,6 +773,7 @@ proc select_cpu_events {cpu_name} { > IBM_Power_Architected_Events_V1 {set type ibm_power_architected_v1} > ARM_Cortex-A57 {set type arm8} > ARM_Cortex-A53 {set type arm8} > + x86-64/generic {set type amd_generic} > } > > verbose "cpu type is $type" > > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > > > > _______________________________________________ > oprofile-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/oprofile-list > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/