broadwell cycle_activity unit mask

Hi Andi,

When reviewing the Michael Petlan's unit mask patch I noticed that one of the broadwell unit masks didn't look quite right.  The cycle_activity seems to have unit mask values with the same values with different names. Is this intentional?

name:cycle_activity type:exclusive default:0x1
	0x1 extra:cmask=1 cycles_l2_pending Counts number of cycles the CPU has at least one pending  demand* load request missing the L2 cache.
	0x8 extra:cmask=8 cycles_l1d_pending Counts number of cycles the CPU has at least one pending  demand load request missing the L1 data cache.
	0x2 extra:cmask=2 cycles_ldm_pending Counts number of cycles the CPU has at least one pending  demand load request (that is cycles with non-completed load waiting for its data from memory subsystem)
	0x4 extra:cmask=4 cycles_no_execute Counts number of cycles nothing is executed on any execution port.
	0x5 extra:cmask=5 stalls_l2_pending Counts number of cycles nothing is executed on any execution port, while there was at least one pending demand* load request missing the L2 cache.    (as a footprint) * includes also L1 HW prefetch requests that may or may not be required by demands
	0x6 extra:cmask=6 stalls_ldm_pending Counts number of cycles nothing is executed on any execution port, while there was at least one pending demand load request.
	0xc extra:cmask=c stalls_l1d_pending Counts number of cycles nothing is executed on any execution port, while there was at least one pending demand load request missing the L1 data cache.
	0x8 extra:cmask=8 cycles_l1d_miss Cycles while L1 cache miss demand load is outstanding.
	0x1 extra:cmask=1 cycles_l2_miss Cycles while L2 cache miss demand load is outstanding.
	0x2 extra:cmask=2 cycles_mem_any Cycles while memory subsystem has an outstanding load.
	0x4 extra:cmask=4 stalls_total Total execution stalls.
	0xc extra:cmask=c stalls_l1d_miss Execution stalls while L1 cache miss demand load is outstanding.
	0x5 extra:cmask=5 stalls_l2_miss Execution stalls while L2 cache miss demand load is outstanding.
	0x6 extra:cmask=6 stalls_mem_any Execution stalls while memory subsystem has an outstanding load.

Shouldn't that also be using a name default rather than a numerical value?

-Will

------------------------------------------------------------------------------