Issue with OProfile testsuite patch: Avoid matching anon_remap executable name and only match "anon" samples

"Carl E. Love" <[email protected]>
Newsgroups gmane.linux.oprofile
Message-ID <1438727323.6062.81.camel@oc3328482554>
Rei:

The recent OProfile testsuite change:

Avoid matching anon_remap executable name and only match
 "anon" samples

Signed-off-by: William Cohen <[email protected]>
---
 testsuite/lib/op_workloads.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/lib/op_workloads.exp
b/testsuite/lib/op_workloads.exp
index 88676ba..661e280 100644
--- a/testsuite/lib/op_workloads.exp
+++ b/testsuite/lib/op_workloads.exp
@@ -59,5 +59,5 @@ set op_workload_table(anon_remap)                  \
       {workloads/anon_remap_src/anon_remap.c}      \
       {}                                           \
       {}                                           \
-      {anon}                                       \
+      { anon }                                       \
     }

Has resulted in the test failing on the Power platform to match on the
anon symbol.  It looks like you do not want to match the executable
"anon_remap_bin" but rather only match the symbol
"initialize_anon_func".  If that is the case, then that is what we
should match on, i.e. the change should be:

+      {initialize_anon_func}                       \

This change does seem to work on the Power system that I tested. Let me
know if I am understanding things correctly.  Please let me know what
you think the proposed change.  Thanks.

                Carl Love
 



------------------------------------------------------------------------------
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.