Re: Issue with OProfile testsuite patch: Avoid matching anon_remap executable name and only match "anon" samples

On Tue, 2015-08-04 at 20:03 -0400, William Cohen wrote:
> On 08/04/2015 06:28 PM, Carl E. Love wrote:
> > 
> > Rei:
> > 
> > The recent OProfile testsuite change:
> > 
> > Avoid matching anon_remap executable name and only match
> >  "anon" samples
> > 
> > Signed-off-by: William Cohen <[email protected]>
> > ---
> >  testsuite/lib/op_workloads.exp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/testsuite/lib/op_workloads.exp
> > b/testsuite/lib/op_workloads.exp
> > index 88676ba..661e280 100644
> > --- a/testsuite/lib/op_workloads.exp
> > +++ b/testsuite/lib/op_workloads.exp
> > @@ -59,5 +59,5 @@ set op_workload_table(anon_remap)                  \
> >        {workloads/anon_remap_src/anon_remap.c}      \
> >        {}                                           \
> >        {}                                           \
> > -      {anon}                                       \
> > +      { anon }                                       \
> >      }
> > 
> > Has resulted in the test failing on the Power platform to match on the
> > anon symbol.  It looks like you do not want to match the executable
> > "anon_remap_bin" but rather only match the symbol
> > "initialize_anon_func".  If that is the case, then that is what we
> > should match on, i.e. the change should be:
> > 
> > +      {initialize_anon_func}                       \
> > 
> > This change does seem to work on the Power system that I tested. Let me
> > know if I am understanding things correctly.  Please let me know what
> > you think the proposed change.  Thanks.
> > 
> >                 Carl Love
> 
> Hi Carl,
> 
> The test is suppose to get sample in the function created in the anon region.  
> The matching should be for samples in that anon region. the patch above was tightening 
> the maching to avoid matching other things with "anon" in the string.  The initialize_anon_func 
> is merely there to create a large function in the anon region and is only run once.  If the 
> test isn't getting samples on the anon region on the machine, then need to figure out what is 
> happening on that machine.  Keep in mind that this test will fail on oprofile-1.0.0 and earlier.  
> It should only pass on oprofile-1.1.0

Will:

I retested using OProfile 1.1.0 and the test does pass as expected with
the latest release.  I have let the user who reported the issue to me
know what is going on.  Thanks for the help with this.

                  Carl Love


------------------------------------------------------------------------------