Re: [PATCH 0/2 RFC] Add time stamp collection to operf and opreport

On Wed, 2015-10-07 at 10:47 -0400, William Cohen wrote:
> Thanks for the patches.  I starting to look at the patches.  I will
> try to have a more complete list of comments before the week is out.
> 
> In addition to the man pages there should be an example use in the
> manual's doc/oprofile.xml.
> 
> It would be really nice if the plotting allowed multiple to be plotted
> at the same time, for example cycles, instructions retired, and cache
> misses. This would make it easier to spot possible cause of a problem.
> Another thing to consider plotting is ratios of counts.  There would
> be a lot of utility in visualizing fluctuations in cycles per
> instructions or cache misses per instruction.
> 
> The process_time_stamps.sh script left some files around in the
> directory after running.  It should clean up after itself.  Also it
> would be nicer if could feed the output of "opreport -T -X" directly
> into the scripts rather than having to write them to a file.
> 
> Should the doc/opreport.xsd andlibpp/xml_utils.cpp schema_version be
> bumped
> due to the additional timestamp element? 

Will:

I have reworked the two patches to add the desired functionality and
documentation you mentioned above.  I bumped the versions in
doc/opreport.xsd and libpp/xml_utils.cpp from 1.0 to 1.1.  I also took
care of the coverity issues you listed.  

I am sending the updated patches for review.  Thanks for the time and
help reviewing the patches.

                Carl Love


------------------------------------------------------------------------------