Re: [PATCH] Remove Powerpc OProfile events the kernel will reject
William Cohen <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
On 11/19/2015 01:50 PM, Carl E. Love wrote: > On Thu, 2015-11-19 at 12:24 -0500, William Cohen wrote: >> On 11/19/2015 11:54 AM, 大平怜 wrote: >>> Carl, Will, >>> >>> After this particular commit, I cannot run any OProfile command, even ophelp, on POWER8. >>> >>> $ ./ophelp --version >>> ./ophelp: oprofile 1.2.0git compiled on Nov 19 2015 10:43:15 >>> $ ./ophelp >>> um rc_machine is not used >>> um L1_latency is not used >>> >>> The previous version on git (commit a58c3953a1c5f5fb00b873a5e22c878f9f4d5a2d) works fine. >>> >>> Could you help fix this problem? >> >> Hi, >> >> It is surprising that commit 34715734fd6f4b44f32206541c8a2500514c9922 is causing things to fail. That commit only changes >> events/ppc64/power8/events. However, there seems to be some checks for unused unit masks. The attached patch seems to address the issue. Could you give it ia try? Carl does this patch look reasonable? >> >> -Will > > Rei, Will: > > Argh, major embarrassment, my event removal patch did break the tool. > It looks like I didn't do a complete rebuild of the tool once I removed > the events. I was able to reproduce the error Rei saw. Yes, it is due > to the unused masks in the mask file. Will's patch fixes the issue. > With the patch applied, the ophelp tool worked. > > I did a fresh pull of OProfile on to a different P8 machine. Compiled > and installed to verify the issue. Then I applied the patch and did a > rebuild and reinstall to verify the patch worked. > > Carl Love > > Hi Carl, Rei, So you are good with the patch itself. How does the following look for the commit text? -Will Remove unused Power 8 unit masks To prevent people from using PMU events that the kernel would reject on Power 8 commit 34715734fd6f commented out those events. However, additional checks in oprofile code would note that some of the unit masks were unused due to those commented out events and prevent oprofile tools from running. The unused unit masks have been commented out to pass these checks. Signed-off-by: William Cohen <[email protected]> ------------------------------------------------------------------------------ _______________________________________________ oprofile-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oprofile-list