Re: [PATCH] Remove Powerpc OProfile events the kernel will reject

Carl,

Could you take a look at the question I asked in the previous email?

> I have a question about your patch.  Your patch removed
> PM_DATA_ALL_FROM_RL2L3_MOD, but this event does not
> cause any error when I specify it to a previous version of OProfile.
> Why does your patch have to remove this event?  Maybe it depends
> on the environment?  I confirmed PM_L2_LD_MISS did cause an error,
> as Chencheng Ye found.  I have not yet checked the other events.


Thanks,
Rei Odaira

2015-11-19 15:44 GMT-06:00 William Cohen <[email protected]>:

> On 11/19/2015 04:00 PM, Carl E. Love wrote:
> > On Thu, 2015-11-19 at 15:13 -0500, William Cohen wrote:
>
> >>
> >> Remove unused Power 8 unit masks
> >>
> >> To prevent people from using PMU events that the kernel would reject
> >> on Power 8 commit 34715734fd6f commented out those events.  However,
> >> additional checks in oprofile code would note that some of the unit
> >> masks were unused due to those commented out events and prevent
> >> oprofile tools from running.  The unused unit masks have been
> >> commented out to pass these checks.
> >>
> >> Signed-off-by: William Cohen <[email protected]>
> >>
> > Looks good.  Thanks.
> >
> >                  Carl Love
>
>
> Okay. the patch is checked in and things should work on Power 8.
>
> -Will
>

------------------------------------------------------------------------------

_______________________________________________
oprofile-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oprofile-list